Fix for popstate firing on page load. #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that this fixes the problem in my app, cheers |
|
@ghempton Sounds good. I assume you've also tested this on browsers that don't trigger the initial popState? |
|
@wagenet yup, I've tested on FF which doesn't trigger on page load. |
|
I have a branch that I'm working on to use replaceState on HistoryLocation init. Would this still be an issue at that point? |
|
@digitaltoad I think this fix will still be needed. |
|
@digitaltoad what is the status of your branch? |
wycats
added a commit
that referenced
this pull request
Oct 15, 2012
Fix for popstate firing on page load.
|
I haven't submitted it due to testing. Not really sure the best way to test that replaceState is used without using replaceState. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Chrome popstate is fired on page load (see http://stackoverflow.com/questions/6421769/popstate-on-pages-load-in-chrome). This causes the initial route to be entered twice. This PR fixes that.
I would add a test for this, but due it it requiring a fresh page load, it is very non-trivial.